fix(sqllab): prev shema/table options remained on fail #29638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
approved these changes
Jul 19, 2024
justinpark
commented
Jul 19, 2024
| @@ -272,7 +272,6 @@ test('should display options in order of the api response', async () => { | |||
| }); | |||
|
|
|||
| test('Should fetch the search keyword when total count exceeds initial options', async () => { | |||
| fetchMock.reset(); | |||
There was a problem hiding this comment.
restore from this accidental removal
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
|
@supersetbot label 4.1 |
github-actions
bot
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 5539f87)
|
@michael-s-molina Please add this hotfix on 4.0 too. |
michael-s-molina
added
the
v4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Due to the difference between the data of the RDK query and currentData, an issue occurred in SQL Lab where, instead of showing an empty selection due to (permission) errors, the schema and table selector allowed the selection of previous database or schema options.
As a result, it was possible to combine schema and table selections that do not actually exist, causing errors and potentially confusing users.
This commit addresses these issues by changing to currentData, ensuring that only results existing in the strictly selected database and schema are displayed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--using-current-data.mov
After:
after--using-current-data.mov
TESTING INSTRUCTIONS
Select a db/schema/tables in Sql Lab page
Choose a db that doesn't allow to access the schemas
See the schema selection remained or not after db selection changed
ADDITIONAL INFORMATION