fix(CrossFilters): Do not reload unrelated filters in global scope

[geido]

SUMMARY

This PR partially accounts for the issue reported on #30061. However, more work is required so that when a scope is applied the frontend can check columns / calculated columns across different datasets to see whether the query should be sent over the backend at all. Working on a follow-up PRs that should solve the issue for both native and cross filters.

BEFORE

before.mp4

AFTER

after.mp4

TESTING INSTRUCTIONS

1. In global scope a cross filter should only affect charts of the same dataset

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[betodealmeida]

👍🏼

[michael-s-molina]

This PR partially accounts for the issue reported on #30061. However, more work is required so that when a scope is applied the frontend can check columns / calculated columns across different datasets to see whether the query should be sent over the backed at all. Working on a follow-up PRs that should solve the issue for both native and cross filters.

@geido Do you have a link for the follow-up that will fix the cross filter issue?

[geido]

This PR partially accounts for the issue reported on #30061. However, more work is required so that when a scope is applied the frontend can check columns / calculated columns across different datasets to see whether the query should be sent over the backed at all. Working on a follow-up PRs that should solve the issue for both native and cross filters.

@geido Do you have a link for the follow-up that will fix the cross filter issue?

Still working on it

[fmannhardt]

@geido I am testing the 4.1 branch and realized that our cross filters are not working anymore. Do I read this PR right in that it would entirely disable cross filtering if the data source is not the same, even if shared columns exist? And that this is fixed, also for columns not actually used in the chart, with: #30438

[geido]

@geido I am testing the 4.1 branch and realized that our cross filters are not working anymore. Do I read this PR right in that it would entirely disable cross filtering if the data source is not the same, even if shared columns exist? And that this is fixed, also for columns not actually used in the chart, with: #30438

That is a good point @fmannhardt . I updated #30438 to make sure we are targeting all possible common columns in all datasources. Let me know if that makes sense to you now.

[fmannhardt]

When testing including #30438 I still do not see the chart being refreshed. The query is correct and also when looking at the result table it is correct but the chart visualization itself does not show up refreshed.

[geido]

When testing including #30438 I still do not see the chart being refreshed. The query is correct and also when looking at the result table it is correct but the chart visualization itself does not show up refreshed.

@fmannhardt would you mind providing a test case to reproduce this issue on my side, please? That would help.

[fmannhardt]

Ok. I will try to provide it. Maybe it had to do with using JINJA templating in a filtering statement.

[fmannhardt]

I have tried to reproduce with the latest changes on the other PR and the issue is gone. Thanks.