Fixing json decode error on druiddatasourcemodelview/api/read #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Jan 25, 2018
superset/connectors/druid/models.py
Outdated
| @@ -91,6 +91,9 @@ class DruidCluster(Model, AuditMixinNullable, ImportMixin): | |||
| def __repr__(self): | |||
| return self.verbose_name if self.verbose_name else self.cluster_name | |||
|
|
|||
| def __html__(self): | |||
| return self.verbose_name if self.verbose_name else self.cluster_name | |||
There was a problem hiding this comment.
Maybe just call self.__repr__() unless you think these method may diverge?
There was a problem hiding this comment.
Good call, fixed this.
michellethomas
force-pushed
the
fix_datasource_api_read
branch
from
57382be
to
f9ee77a
Compare
michellethomas
force-pushed
the
fix_datasource_api_read
branch
from
f9ee77a
to
272f400
Compare
|
LGTM |
michellethomas
added a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been getting a JSON decode error on
druiddatasourcemodelview/api/readand from looking at this issue, it seemed like having a repr method on the DruidCluster model would work, but it seems html is needed as well for DruidDatasources to decode the relationship to DruidCluster correctly.@john-bodley