Add play slider to screengrid #4647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4647 +/- ##
=========================================
- Coverage 72.63% 72.6% -0.04%
=========================================
Files 205 206 +1
Lines 15403 15418 +15
Branches 1183 1184 +1
=========================================
+ Hits 11188 11194 +6
- Misses 4212 4221 +9
Partials 3 3
Continue to review full report at Codecov.
|
|
|
||
| const pattern = new RegExp('^(\\d+)?\\s*(.*)$'); | ||
|
|
||
| export const parseTimeGrain = function (timeGrain) { |
There was a problem hiding this comment.
Wondering if we can have a single authority on time grain parsing between the frontend & backend. Backend has utils.parse_human_datetime leveraging the parsedatetime lib. Just worried there's divergence into what the backend and frontend understand.
The backend could return its understanding of granularity to be available to the frontend in the payload. This may require a bit more thinking.
There was a problem hiding this comment.
Yeah, that would definitely be better. We can pass an ISO 8601 duration as a string. Let me take a look at it.
|
@mistercrunch, I rebased this and now it uses the ISO duration parsing. |
* Improved granularity parsing * Add unit tests * Explicit cast to int * Screengrid play slider * Clean code * Refactor common code
* Improved granularity parsing * Add unit tests * Explicit cast to int * Screengrid play slider * Clean code * Refactor common code
* Improved granularity parsing * Add unit tests * Explicit cast to int * Screengrid play slider * Clean code * Refactor common code
mistercrunch
added
🏷️ bot
Note: this is based on #4623.