Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database type inference #4724

Merged
merged 8 commits into from
Jun 28, 2018
Merged

Improve database type inference #4724

merged 8 commits into from
Jun 28, 2018

Commits on Jun 27, 2018

  1. Improve database type inference 

    Python's DBAPI isn't super clear and homogeneous on the
cursor.description specification, and this PR attempts to improve
inferring the datatypes returned in the cursor.

This work started around Presto's TIMESTAMP type being mishandled as
string as the database driver (pyhive) returns it as a string. The work
here fixes this bug and does a better job at inferring MySQL and Presto types.
It also creates a new method in db_engine_specs allowing for other
databases engines to implement and become more precise on type-inference
as needed.
    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    77a8475 View commit details
    Browse the repository at this point in the history

  2. Fixing tests

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    381d774 View commit details
    Browse the repository at this point in the history

  3. Adressing comments

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    717dec6 View commit details
    Browse the repository at this point in the history

  4. Using infer_objects

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    2d29bb0 View commit details
    Browse the repository at this point in the history

  5. Removing faulty line

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    b630aef View commit details
    Browse the repository at this point in the history

  6. Addressing PrestoSpec redundant method comment

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    c1c9f3f View commit details
    Browse the repository at this point in the history

  7. Fix rebase issue

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    5127fdd View commit details
    Browse the repository at this point in the history

  8. Fix tests

    @mistercrunch
    mistercrunch committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    437bbf4 View commit details
    Browse the repository at this point in the history