[formats] add better defaults for time + number formatting #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
force-pushed
the
chris--better-timeseries-tick-format
branch
from
69f6d94
to
ee3cdf9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4843 +/- ##
=======================================
Coverage 76.96% 76.96%
=======================================
Files 44 44
Lines 8534 8534
=======================================
Hits 6568 6568
Misses 1966 1966Continue to review full report at Codecov.
|
|
it looks like the verbose format is not always being used in the tooltip, will fix this / if you have tips ( ;) ) let me know |
|
Tested this with a bunch of production examples and fixed a bug where
|
|
It would be nice to add quarters -Q1, Q2, Q3, Q4 |
|
@oxydash while I agree that'd be nice, it's not trivial:
|
|
Looks good, this should fix a lot of axis label problems. |
fabianmenges
approved these changes
Apr 20, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [formats] add better defaults for time + number formatting * [formatDate] add tests for concise formatDate * [nvd3] use verbose time format in tooltips * [number format] improve number format description * [formats] revert to .3s defaults, tweak number format preview * [formats] default number vis to .3s
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* [formats] add better defaults for time + number formatting * [formatDate] add tests for concise formatDate * [nvd3] use verbose time format in tooltips * [number format] improve number format description * [formats] revert to .3s defaults, tweak number format preview * [formats] default number vis to .3s
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [formats] add better defaults for time + number formatting * [formatDate] add tests for concise formatDate * [nvd3] use verbose time format in tooltips * [number format] improve number format description * [formats] revert to .3s defaults, tweak number format preview * [formats] default number vis to .3s
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is all about making better default for time + number formatting 🚀 It adds:
a more concise multi-format tick formatter. Here is the before and after (and you can play with it in this observable notebook):
sets most default number formats to 1 decimal place instead of 3
reduces the number of y-axis ticks (to ~5), there is no need for ~10+ that nvd3 sets by default
rich tooltip => false by default, this makes tooltips look pretty bad, you can still hover over individual lines to see their values, or toggle on rich tooltips if you want them.
@mistercrunch @hughhhh @john-bodley @graceguo-supercat @michellethomas @fabianmenges