-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heatmap improvements #4897
Heatmap improvements #4897
Conversation
mistercrunch
commented
Apr 27, 2018
- allow option to normalize the color distribution
- make bounds work client side (instantaneous)
- make more controls instantaneous
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous
Codecov Report
@@ Coverage Diff @@
## master #4897 +/- ##
==========================================
+ Coverage 77.13% 77.14% +<.01%
==========================================
Files 44 44
Lines 8542 8539 -3
==========================================
- Hits 6589 6587 -2
+ Misses 1953 1952 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can always use more instant controls. :)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
hey @mistercrunch it looks like this causes an issue with heatmaps that use It also looks like without the value bounds the legend is always showing the normalized 0-1 range. I can take a screenshot if the description is not clear. I'm testing on internal data so I'd just need to load test data. |
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous (cherry picked from commit 3c7feb7)
* allow option to normalize the color distribution * make bounds work client side (instantaneous) * make more controls instantaneous