[ad-hoc filters] Fixing legacy conversion #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-fix-convert-legacy-filters
branch
from
ec204b5
to
4cdbd98
Compare
|
LGTM |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Aug 13, 2018
(cherry picked from commit d1ef81f)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where previously the assumption was that the presence of the
adhhoc_filtersfield in the form data informed that it should trump (and remove) any legacy filters, however it's been brought to our attention that the field could have been previously defined.The solution is to convert legacy filters if i) the
adhoc_filtersfield is undefined or ii) the associated value isNoneor an empty list, i.e., falsy.to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch