[explore flow] handling duplicated column aliases #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hey @mistercrunch we should avoid using that red color for buttons unless clicking that button will lead to something critical such as deleting something. |
Codecov Report
@@ Coverage Diff @@
## master #5778 +/- ##
==========================================
+ Coverage 63.77% 63.78% +0.01%
==========================================
Files 364 364
Lines 23097 23112 +15
Branches 2572 2588 +16
==========================================
+ Hits 14729 14743 +14
- Misses 8353 8354 +1
Partials 15 15
Continue to review full report at Codecov.
|
|
|
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* [explore flow] handling duplicated column aliases closes apache#5739 * lint (cherry picked from commit 75bc501)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5739
