Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flask-appbuilder to latest. #6030

Merged
merged 3 commits into from
Oct 8, 2018

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Oct 4, 2018

Not sure if the alembic issue on fab 1.11 is still going on. Anybody have tips on testing that out?

@jmcarp jmcarp force-pushed the upgrade-flask-appbuilder branch 5 times, most recently from c216e4e to 0bd1630 Compare October 6, 2018 14:10
@jmcarp jmcarp mentioned this pull request Oct 6, 2018
@codecov-io
Copy link

codecov-io commented Oct 6, 2018

Codecov Report

Merging #6030 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6030     +/-   ##
=========================================
+ Coverage   77.74%   77.85%   +0.1%     
=========================================
  Files          46       46             
  Lines        9400     9400             
=========================================
+ Hits         7308     7318     +10     
+ Misses       2092     2082     -10
Impacted Files Coverage Δ
superset/views/utils.py 93.93% <ø> (ø) ⬆️
superset/views/base.py 68% <100%> (ø) ⬆️
superset/security.py 75.55% <100%> (ø) ⬆️
superset/connectors/sqla/models.py 81.2% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93fe453...2624b6e. Read the comment docs.

@jmcarp
Copy link
Contributor Author

jmcarp commented Oct 6, 2018

cc @mistercrunch; I think this can replace #6044.

@mistercrunch
Copy link
Member

Can you add a note in https://github.com/apache/incubator-superset/blob/master/UPDATING.md 0.28.0 about flask-login being upgraded to a backward incompatible version (>0.3.0 ?) which makes g.user.is_anonymous and g.user.is_active, and other attributes go from method to properties?

This may affect users using g.user.* in their superset_config.py

@mistercrunch mistercrunch merged commit 9dcf8e1 into apache:master Oct 8, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Upgrade flask-appbuilder to latest.

* Skip constraint deletes if not exist.

* Document breaking change in flask-login.
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
* Upgrade flask-appbuilder to latest.

* Skip constraint deletes if not exist.

* Document breaking change in flask-login.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants