Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypress][sqllab] increase timeout for sqllab results #6089

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

williaster
Copy link
Contributor

@williaster williaster commented Oct 12, 2018

This increases the timeout waiting for SQL lab results table from the Cypress default of 4s to 10s with the hopes of making it less flaky.

Although the test is not flaky locally, you can see from the local Cypress UI that the saved query pane takes some time to load (not sure why). Note I've already added explicit route alias wait statements as Cypress recommends (e.g., cy.wait('@sqlLabQuery') ), so hopefully this timeout will reduce the overall flakiness on CI.

@kristw @graceguo-supercat @xtinec

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #6089 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6089   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files          47       47           
  Lines        9484     9484           
=======================================
  Hits         7356     7356           
  Misses       2128     2128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7b64f...650f75d. Read the comment docs.

@williaster
Copy link
Contributor Author

thank god this passed 🙏

@williaster williaster merged commit 1d2b1aa into master Oct 12, 2018
@williaster williaster deleted the chris--fix-flaky-cypress-sqllab branch October 12, 2018 18:21
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants