Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cypress][sqllab] increase timeout for sqllab results #6089

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[cypress][sqllab] increase timeout for sqllab results #6089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/assets/cypress/integration/sqllab/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default () => {

cy.wait('@sqlLabQuery');

cy.get('.SouthPane .ReactVirtualized__Table')
selectResultsTab()
.eq(0) // ensures results tab in case preview tab exists
.then((tableNodes) => {
const [header, bodyWrapper] = tableNodes[0].childNodes;
Expand Down
3 changes: 2 additions & 1 deletion superset/assets/cypress/integration/sqllab/sqllab.helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export const selectResultsTab = () => cy.get('.SouthPane .ReactVirtualized__Table');
export const selectResultsTab = () =>
cy.get('.SouthPane .ReactVirtualized__Table', { timeout: 10000 });

// this function asserts that the result set for two SQL lab table results are equal
export const assertSQLLabResultsAreEqual = (resultsA, resultsB) => {
Expand Down