Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in load-examples command #6193

Merged
merged 1 commit into from Oct 26, 2018
Merged

Conversation

maxg203
Copy link
Contributor

@maxg203 maxg203 commented Oct 25, 2018

Noticed an incorrect command in the installation instructions that caused me the error as described in issue #6172.

Related issue: #6172
Related pull request: #6167

@codecov-io
Copy link

Codecov Report

Merging #6193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6193   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files          47       47           
  Lines        9388     9388           
=======================================
  Hits         7222     7222           
  Misses       2166     2166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5fc42...2c3baa1. Read the comment docs.

@mistercrunch mistercrunch merged commit 9580103 into apache:master Oct 26, 2018
@mistercrunch
Copy link
Member

Yeah click made backward incompatible changes around underscore/dashes...

@mistercrunch
Copy link
Member

Thanks for fixing the docs!

@maxg203
Copy link
Contributor Author

maxg203 commented Oct 26, 2018

@mistercrunch I wonder if issues could also crop up based on other occurences of the commands with underscores seen here... https://github.com/apache/incubator-superset/search?q=load_examples&unscoped_q=load_examples

bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants