Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] handle Loading spinner properly #6292

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

mistercrunch
Copy link
Member

Addressing post-merge comments in
#6283

Addressing post-merge comments in
apache#6283
@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #6292 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6292   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files          64       64           
  Lines        9508     9508           
=======================================
  Hits         7323     7323           
  Misses       2185     2185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e8df4...17838c4. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit aed774e into apache:master Nov 7, 2018
@mistercrunch mistercrunch deleted the fix_chart_status2 branch November 7, 2018 21:04
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants