Fix scheduled reports for mysql #6512
Conversation
|
would anyone know why it locks up sqlite? |
|
yes, I tried this way a few days ago. It works with mysql. I also met problem that db is locked when I try to update a dashboard email schedule or slice email schedule. |
|
@cloud26 - can you please confirm that the dashboard email schedule editing was not locking after this fix? Once you confirm, I will merge this in. Thank you @phoenix24 for the approval. |
|
What is the MySQL issue you are referring to? |
|
Sorry for late reply, I got a lot things to do last week. |
setup.py
Outdated
| @@ -94,9 +94,6 @@ def get_git_sha(): | |||
| 'thrift-sasl>=0.2.1', | |||
| 'unicodecsv', | |||
| 'unidecode>=0.04.21', | |||
| 'croniter==0.3.25', | |||
There was a problem hiding this comment.
Are these deps not required anymore?
There was a problem hiding this comment.
(apologies for the late reply here. I was on vacation and traveling)
These dependencies are still needed, but they are specified in requirements.txt already. Did not want to keep it in two places.
There was a problem hiding this comment.
requirements.txt is a pip-compiled, "pinned" version of what's in here. We probably want to keep this in here though I think it belong in an extra_requires sub-category, but that's outside the scope of this PR. For now let's just keep this in the repo. Mind remove these edits from this PR?
There was a problem hiding this comment.
@mistercrunch removed the edits. Let me know if you are OK with it and I will merge it in.
@mistercrunch this was the issue. |
setup.py
Outdated
| @@ -94,9 +94,6 @@ def get_git_sha(): | |||
| 'thrift-sasl>=0.2.1', | |||
| 'unicodecsv', | |||
| 'unidecode>=0.04.21', | |||
| 'croniter==0.3.25', | |||
There was a problem hiding this comment.
requirements.txt is a pip-compiled, "pinned" version of what's in here. We probably want to keep this in here though I think it belong in an extra_requires sub-category, but that's outside the scope of this PR. For now let's just keep this in the repo. Mind remove these edits from this PR?
Codecov Report
@@ Coverage Diff @@
## master #6512 +/- ##
=======================================
Coverage 56.24% 56.24%
=======================================
Files 518 518
Lines 23007 23007
Branches 2750 2750
=======================================
Hits 12941 12941
Misses 9655 9655
Partials 411 411
Continue to review full report at Codecov.
|
mahendra
force-pushed
the
fix-scheduled-emails-mysql
branch
from
7ef2773
to
e25a56f
Compare
|
@mistercrunch approve please? |
mistercrunch
added
🏷️ bot
@mistercrunch @timifasubaa @cloud26 - A tentative fix to the mysql issue.
I tried it with postgres and it works.
Sqlite db - I get errors saying "db is locked".
@cloud26 - can you try it with mysql please?