fix: Gunicorn raise encoding error #7010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7010 +/- ##
==========================================
+ Coverage 64.46% 67.39% +2.92%
==========================================
Files 421 422 +1
Lines 20521 23902 +3381
Branches 2245 2478 +233
==========================================
+ Hits 13229 16108 +2879
- Misses 7165 7665 +500
- Partials 127 129 +2
Continue to review full report at Codecov.
|
john-bodley
reviewed
Mar 13, 2019
| @@ -320,7 +320,8 @@ class CsvResponse(Response): | |||
| """ | |||
| Override Response to take into account csv encoding from config.py | |||
| """ | |||
| charset = conf.get('CSV_EXPORT').get('encoding', 'utf-8') | |||
| _charset = conf.get('CSV_EXPORT').get('encoding', 'utf-8') | |||
| charset = 'utf-8' if _charset.lower() == 'utf-8-sig' else _charset | |||
There was a problem hiding this comment.
Out of interest why are you using the utf-8-sig encoding rather than utf-8?
There was a problem hiding this comment.
utf-8-sig is utf-8 encoding with BOM, and this is microsoft Excel detect utf-8 encoding.
In this scenarios, if use Excel open to east asian charset by Excel without BOM, excel show garbled.
kristw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to:
#5377
benoitc/gunicorn#1778
on Python3 gunicorn encoding header by ascii, not support 'utf-8-sig' charset,
, so we need replace utf-8-sig charset for header encoding