Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [lyftga] update necessary packages #7205

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

khtruong
Copy link
Contributor

@khtruong khtruong commented Apr 2, 2019

SUMMARY

I made updates to color, big number, and nvd3 packages.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[ ] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec

@xtinec xtinec added lyft Related to Lyft minor-review labels Apr 2, 2019
Copy link
Contributor

@xtinec xtinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khtruong khtruong changed the title Update necessary packages chore: update necessary packages Apr 2, 2019
@khtruong khtruong changed the title chore: update necessary packages chore: [lyftga] update necessary packages Apr 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #7205 into lyftga will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           lyftga   #7205   +/-   ##
======================================
  Coverage    64.5%   64.5%           
======================================
  Files         424     424           
  Lines       20668   20668           
  Branches     2268    2268           
======================================
  Hits        13332   13332           
  Misses       7213    7213           
  Partials      123     123

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cfb2d...c74f06c. Read the comment docs.

@xtinec xtinec merged commit 74a0b57 into apache:lyftga Apr 2, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lyft Related to Lyft 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants