Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB] set AppBuilder to update_perms=False #7561

Merged
merged 2 commits into from
Jun 1, 2019

Conversation

mistercrunch
Copy link
Member

CATEGORY

  • Build / Development Environment

SUMMARY

Upon start, by default, FAB tries to go and update the permission list
in the database based on the list of views, models and menu items that
exist in the code.

Really this should happen once per deployment/upgrade and
not in module scope, so we have superset init for this.

The intent was always to set to False by default, but I think we forgot
to add this flag back in
#7323

Upon start, by default, FAB tries to go and update the permission list
in the database based on the list of views, models and menu items that
exist in the code.

Really this should happen once per deployment/upgrade and
not in module scope, so we have `superset init` for this.

The intent was always to set to False by default, but I think we forgot
to add this flag back in
apache#7323
@codecov-io
Copy link

Codecov Report

Merging #7561 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7561      +/-   ##
==========================================
- Coverage   65.59%   65.57%   -0.03%     
==========================================
  Files         435      435              
  Lines       21694    21694              
  Branches     2387     2387              
==========================================
- Hits        14230    14225       -5     
- Misses       7343     7348       +5     
  Partials      121      121
Impacted Files Coverage Δ
superset/__init__.py 73.52% <ø> (ø) ⬆️
superset/security.py 73.24% <0%> (-1.76%) ⬇️
superset/utils/core.py 88.06% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722043c...e358b12. Read the comment docs.

@michellethomas
Copy link
Contributor

Thanks Max lgtm

@mistercrunch mistercrunch merged commit eb42936 into apache:master Jun 1, 2019
michellethomas pushed a commit that referenced this pull request Jun 19, 2019
* [FAB] set AppBuilder to update_perms=False

Upon start, by default, FAB tries to go and update the permission list
in the database based on the list of views, models and menu items that
exist in the code.

Really this should happen once per deployment/upgrade and
not in module scope, so we have `superset init` for this.

The intent was always to set to False by default, but I think we forgot
to add this flag back in
#7323

* Add superset init to tox

(cherry picked from commit eb42936)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* [FAB] set AppBuilder to update_perms=False

Upon start, by default, FAB tries to go and update the permission list
in the database based on the list of views, models and menu items that
exist in the code.

Really this should happen once per deployment/upgrade and
not in module scope, so we have `superset init` for this.

The intent was always to set to False by default, but I think we forgot
to add this flag back in
apache#7323

* Add superset init to tox

(cherry picked from commit bfd7818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants