[FAB] set AppBuilder to update_perms=False #7561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in apache#7323
mistercrunch
force-pushed
the
fab_update_perms_false
branch
from
aae628b
to
e358b12
Compare
Codecov Report
@@ Coverage Diff @@
## master #7561 +/- ##
==========================================
- Coverage 65.59% 65.57% -0.03%
==========================================
Files 435 435
Lines 21694 21694
Branches 2387 2387
==========================================
- Hits 14230 14225 -5
- Misses 7343 7348 +5
Partials 121 121
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Jun 1, 2019
|
Thanks Max lgtm |
michellethomas
pushed a commit
that referenced
this pull request
Jun 19, 2019
* [FAB] set AppBuilder to update_perms=False Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in #7323 * Add superset init to tox (cherry picked from commit eb42936)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* [FAB] set AppBuilder to update_perms=False Upon start, by default, FAB tries to go and update the permission list in the database based on the list of views, models and menu items that exist in the code. Really this should happen once per deployment/upgrade and not in module scope, so we have `superset init` for this. The intent was always to set to False by default, but I think we forgot to add this flag back in apache#7323 * Add superset init to tox (cherry picked from commit bfd7818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Upon start, by default, FAB tries to go and update the permission list
in the database based on the list of views, models and menu items that
exist in the code.
Really this should happen once per deployment/upgrade and
not in module scope, so we have
superset initfor this.The intent was always to set to False by default, but I think we forgot
to add this flag back in
#7323