[SQL Lab] fix unnecessary offline action #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7594 +/- ##
=========================================
+ Coverage 65.21% 65.32% +0.1%
=========================================
Files 435 435
Lines 21480 21486 +6
Branches 2381 2382 +1
=========================================
+ Hits 14008 14035 +27
+ Misses 7352 7331 -21
Partials 120 120
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 31, 2019
(cherry picked from commit dbdb6b0)
michellethomas
pushed a commit
that referenced
this pull request
Jun 1, 2019
(cherry picked from commit dbdb6b0)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 5cc5c96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
QueryAutoRefresh polls running query's status every 2 seconds. if query is running good, it calls
setUserOffline(for every 2 seconds). Because Sql Lab uses redux-localStorage to sync redux state to localStorage, any time an action is dispatched in redux it will trigger localStorage update (even without any change), which is very unnecessary when there is no real state change.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: i used redux chrome extension to show redux state update:
TEST PLAN
CI and manual check.
ADDITIONAL INFORMATION
REVIEWERS
@michellethomas @mistercrunch @williaster