Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showing the values on top of the bars #777

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Jul 15, 2016

In "Time Series - Bar Chart" and "Distribution - Bar Chart", there is a new toggle "Bar Values". The values of the bars will be shown on top of the bars if the toggles are switched on.

@coveralls
Copy link

coveralls commented Jul 15, 2016

Coverage Status

Coverage remained the same at 81.185% when pulling 9cc163c on x4base:show_bar_value into 2b237f4 on airbnb:master.

@mistercrunch
Copy link
Member

screenshot please!

@x4base
Copy link
Contributor Author

x4base commented Jul 21, 2016

You will have to switch "Bar Values" on to see the values
screen shot 2016-07-21 at 12 51 53 pm
screen shot 2016-07-21 at 12 52 06 pm

@alanmcruickshank
Copy link
Contributor

While you're in that part of the codebase could you add the same option for
piecharts too? Would be great to have the option to show either the % as a
number, or the absolute value or both.

On Thu, 21 Jul 2016 05:56 x4base, notifications@github.com wrote:

You will have to switch "Bar Values" on to see the values
[image: screen shot 2016-07-21 at 12 51 53 pm]
https://cloud.githubusercontent.com/assets/1527501/17011622/595b2336-4f42-11e6-93fa-3bf49e53ddaa.png
[image: screen shot 2016-07-21 at 12 52 06 pm]
https://cloud.githubusercontent.com/assets/1527501/17011625/5eddd29a-4f42-11e6-9132-7bd45983c287.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#777 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEdFuNHp8ho2PwQX24SYpOTiIEJYJ0mwks5qXvvhgaJpZM4JNoow
.


Alan Cruickshank
E: alanmcruickshank@gmail.com
T: +44 770 6851825

@mistercrunch mistercrunch merged commit f43e5f1 into apache:master Jul 26, 2016
@x4base
Copy link
Contributor Author

x4base commented Jul 26, 2016

@alanmcruickshank
Sorry for the late reply. I implemented it in #819 .

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants