Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the user decide the label type of pie charts #819

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Let the user decide the label type of pie charts #819

merged 1 commit into from
Jul 28, 2016

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Jul 26, 2016 •
edited
Loading

The user can choose the label type from "Category Name", "Value", and "Percentage". The user can also decide whether the labels should be outside or inside the pie.
screen shot 2016-07-26 at 12 59 24 pm
screen shot 2016-07-26 at 12 59 36 pm
screen shot 2016-07-26 at 12 59 47 pm

@x4base x4base mentioned this pull request Jul 26, 2016
Merged
@coveralls
Copy link

coveralls commented Jul 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 81.012% when pulling 8c38413 on x4base:pie_label_type into f43e5f1 on airbnb:master.

@alanmcruickshank
Copy link
Contributor

Nice!

On Tue, 26 Jul 2016 06:19 Coveralls, notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/7161094

Coverage decreased (-0.03%) to 80.981% when pulling 8c38413
8c38413
on x4base:pie_label_type into f43e5f1
f43e5f1
on airbnb:master.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#819 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEdFuEhNzG4wwg_C8exQzrG-K5MDNsfcks5qZZjYgaJpZM4JUyrF
.

Alan Cruickshank
E: alanmcruickshank@gmail.com
T: +44 770 6851825

@georgeke
Copy link
Contributor

lgtm!

@mistercrunch
Copy link
Member

mistercrunch commented Jul 28, 2016 •
edited
Loading

The best pie gif I could find:
img

@mistercrunch mistercrunch merged commit 29e3dd4 into apache:master Jul 28, 2016
@vera-liu vera-liu mentioned this pull request Oct 25, 2016
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@x4base @coveralls @alanmcruickshank @georgeke @mistercrunch