[SQL Lab] Fix TableSelector perf for large option sets #7868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--table-selector-perf
branch
from
4f7fe94
to
0bffc15
Compare
| placeholder={t('Select table or type table name')} | ||
| autosize={false} | ||
| onChange={this.changeTable} | ||
| filterOptions={this.state.filterOptions} |
There was a problem hiding this comment.
there is a unit test for filterOptions prop. are you sure to remove it?
|
Does this get rid of autocomplete? |
|
@khtruong nope, autocomplete still works as before. |
khtruong
approved these changes
Jul 22, 2019
etr2460
force-pushed
the
erik-ritter--table-selector-perf
branch
from
0bffc15
to
28f591a
Compare
12 tasks
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #7868 +/- ##
==========================================
+ Coverage 65.8% 65.83% +0.02%
==========================================
Files 461 461
Lines 22210 22210
Branches 2425 2425
==========================================
+ Hits 14616 14621 +5
+ Misses 7473 7468 -5
Partials 121 121
Continue to review full report at Codecov.
|
alex-mark
pushed a commit
to alex-mark/incubator-superset
that referenced
this pull request
Jul 29, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
If you have a large number of tables with a single schema (we have 28k in one of ours), it would take about 10 seconds to load the table selector. This was due to generating the search index, tokenizing, and doing other search-y related things. It turns out that getting rid of the indexing and adding
ignoreAccents={false}(the same thing as #7791) improves the loading speed (down to under half a second) without hurting the search speed.TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat @michellethomas @khtruong @mistercrunch