[revert] Partial revert of #7888 #7933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--partial-revert-7888
branch
from
7240085
to
caf7e6c
Compare
etr2460
approved these changes
Jul 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #7933 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 468 468
Lines 22297 22296 -1
Branches 2429 2429
==========================================
- Hits 14710 14709 -1
Misses 7466 7466
Partials 121 121
Continue to review full report at Codecov.
|
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jul 29, 2019
12 tasks
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 29, 2019
[cherry-pick] Picking apache#7933
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This is a partial revert of #7888 where it was discovered that this breaks filter_values logic (which is used within custom SQL views and can reference columns not present in the UI) which simply ignores invalid filters. By raising an exception prematurely one could cause functional charts to break.
Personally I think the long term fix is to rethink the filter logic however this is non-trivial and thus in the interim reverting the logic for raising on invalid filters is being reverted.
TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @michellethomas @mistercrunch
cc: @williaster