Avoid fetch fav dashboard stat not logged in

[aspedrosa]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

As explained in #8501, if you allow non logged in users to see dashboards, the favorite status of that dashboard will still be fetched, causing an error toast to appear.
To fix it I check if the userId present on the dashboardInfo prop of the Header component is valid, and only if it is, the span related to the fav-star is rendered.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

There's already a test that verifies if the fav-start is displayed and works correctly

ADDITIONAL INFORMATION

• Has associated issue: Still fetching fav-star data when no user is logged in #8501
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

[codecov-io]

Codecov Report

Merging #8527 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8527      +/-   ##
==========================================
- Coverage   66.68%   66.67%   -0.01%     
==========================================
  Files         449      449              
  Lines       22687    22698      +11     
  Branches     2366     2368       +2     
==========================================
+ Hits        15128    15135       +7     
- Misses       7421     7425       +4     
  Partials      138      138

Impacted Files	Coverage Δ
...uperset/assets/src/dashboard/components/Header.jsx	43.24% <100%> (+1.04%)	⬆️
superset/db_engine_specs/postgres.py	55.55% <0%> (-27.78%)	⬇️
superset/db_engine_specs/base.py	80.33% <0%> (-0.26%)	⬇️
superset/views/database/forms.py	91.11% <0%> (ø)	⬆️
superset/assets/src/setup/setupColors.js	0% <0%> (ø)	⬆️
superset/db_engine_specs/hive.py	28.18% <0%> (+0.32%)	⬆️
superset/views/database/views.py	92.15% <0%> (+8.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec476fc...68390e7. Read the comment docs.

[etr2460]

lgtm, thanks for adding tests too!

[nytai]

👍 🎉

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[willbarrett]

nudge to @dpgaspar, @mistercrunch, and @craig-rueda that this appears ready for merge.