Removing (unused?) Victory theme file #9063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9063 +/- ##
==========================================
+ Coverage 59.45% 59.51% +0.06%
==========================================
Files 369 368 -1
Lines 11747 11734 -13
Branches 2888 2888
==========================================
Hits 6984 6984
+ Misses 4584 4571 -13
Partials 179 179Continue to review full report at Codecov.
|
willbarrett
approved these changes
Feb 13, 2020
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Just stumbled upon this theme file for Victory which doesn't seem to be used or referred to anywhere in
incubator-supersetorsuperset-uiorsuperset-ui-pluginsinsofar as I can tell.Should be safe to delete this, unless... I'm mistaken :)