fix: change database save in DatasourceEditor #9255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the issue where pointing a datasource to another database in the datasource editor is not reflected. Also addresses: - a minorcosmetic issue in the datasource editor. - user/owners list not getting populated
mistercrunch
force-pushed
the
fix_db_save
branch
4 times, most recently
from
ba0a93b
to
696ce3c
Compare
mistercrunch
force-pushed
the
fix_db_save
branch
from
696ce3c
to
c125195
Compare
Codecov Report
@@ Coverage Diff @@
## master #9255 +/- ##
=======================================
Coverage 58.92% 58.92%
=======================================
Files 373 373
Lines 12016 12016
Branches 2948 2948
=======================================
Hits 7081 7081
Misses 4756 4756
Partials 179 179
Continue to review full report at Codecov.
|
willbarrett
approved these changes
Mar 9, 2020
| @@ -745,6 +745,7 @@ def import_dashboards(self): | |||
| try: | |||
| dashboard_import_export.import_dashboards(db.session, f.stream) | |||
| except DatabaseNotFound as e: | |||
| logger.exception(e) | |||
| @@ -268,7 +268,7 @@ def create_fake_db(self): | |||
| cls=models.Database, | |||
| criteria={"database_name": database_name}, | |||
| session=db.session, | |||
| sqlalchemy_uri="sqlite://test", | |||
| sqlalchemy_uri="sqlite:///:memory:", | |||
| @@ -18,6 +18,7 @@ | |||
| datasource_post = { | |||
| "id": None, | |||
| "column_formats": {"ratio": ".2%"}, | |||
| "database": {"id": 1}, | |||
There was a problem hiding this comment.
Eventually it would be good to move these to randomly generated IDs (note to self)
There was a problem hiding this comment.
Yes, actually here I replace it in the test itself. Not sure what the proper approach here, a function that receives an object and returns a fixture? I'm guessing with DAO abstraction we can get more creative on generating proper fixtures.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue where pointing a datasource to another database
in the datasource editor is not reflected.
Also addresses:
CATEGORY
Choose one