Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add controlGroups to formData #9740

Merged
merged 1 commit into from
May 6, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented May 5, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This adds a field controlGroups to formData to facilitate automatic control grouping for chart data requests.

TEST PLAN

CI

ADDITIONAL INFORMATION

REVIEWERS

@kristw @rusackas @suddjian

@@ -107,6 +109,7 @@ describe('controlUtils', () => {
name: 'all_columns',
config: {
type: 'SelectControl',
controlGroup: 'columns',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming suggestions are welcomed. I went between requestGroup and controlGroup, bud decided in favor of controlGroup, as I expect it will be more intuitive for viz developers.

@rusackas rusackas self-requested a review May 5, 2020 17:11
@villebro villebro merged commit 5485eb9 into apache:master May 6, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants