Sketching the middleware refresh for Queries #991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
force-pushed
the
auto_refresh_query
branch
from
7873157
to
0c35fec
Compare
| // new object with an altered property | ||
| const idKey = 'id'; | ||
| const newArr = []; | ||
| state[arrKey].forEach((arrItem) => { |
There was a problem hiding this comment.
nit: map is a bit more idiomatic
bkyryliuk
force-pushed
the
auto_refresh_query
branch
4 times, most recently
from
ab3d5ea
to
d09becd
Compare
bkyryliuk
force-pushed
the
auto_refresh_query
branch
from
d09becd
to
d5acb99
Compare
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ascott , I was sketching out a potential way to run the middleware refresh from the database with @bkyryliuk (specifically for query state/progress), do you think the approach bellow is reasonable?
I'm basically wrapping the timer into a React component. The component would call a redux action passing a list a queries that have changed recently.