Refactor the queries to be stored as a dict. #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,12 +9,17 @@ import { Alert } from 'react-bootstrap'; | |||
|
|
|||
| const QueryHistory = (props) => { | |||
| const activeQeId = props.tabHistory[props.tabHistory.length - 1]; | |||
| const queries = props.queries.filter((q) => (q.sqlEditorId === activeQeId)); | |||
| if (queries.length > 0) { | |||
| var queries_array = [] | |||
There was a problem hiding this comment.
this is probably failing in the linter, should be const queriesArray = [];
this is the style guide we are using.
|
i think we were reviewing at the same time @mistercrunch :) |
|
JS tests are fine, carapal branch is broken - I'll fix it in the separate PR.
|
| this.props.queries.forEach((q) => { | ||
| if (q.id === qe.latestQueryId) { | ||
| latestQuery = q; | ||
| for (var key in this.props.queries) { |
There was a problem hiding this comment.
no need for a loop!
let latestQuery = this.props.queries[qe.latestQueryId]
mistercrunch
pushed a commit
that referenced
this pull request
Aug 28, 2016
mistercrunch
added a commit
that referenced
this pull request
Aug 30, 2016
* Carapal react mockup This is really just a mock up written in React to try different components. It could become scaffolding to build a prototype, or not. * Merging in Alanna's theme tweaks for SQL lab * Tweak the display of the alert message in navbar * Sketching the middleware refresh for Queries * Adjustments * Implement timer sync. * CTAS * Refactor the queries to be stored as a dict. (#994) * Download csv endpoint. (#992) * CSV download engdpoint. * Use lower case booleans. * Replcate loop with the object lookup by key. * First changes for the sync * Address comments * Fix query deletions. Update only the queries from the store. * Sync queries using tmp_id. * simplify * Fix the tests in the carapal. (#1023) * Sync queries using tmp_id. * Fix the unit tests * Bux fixes. Pass 2. * Tweakin' & linting * Adding alpha label to the SQL LAb navbar entry * Fixing the python unit tests
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch, @ascott - please take a look.
I refactored the redux store to store the queries as dictionary.
I will make the synchronisation logic with the server a bit easier.