Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump sinon to latest stable version #9926

Merged
merged 1 commit into from
May 27, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented May 27, 2020

SUMMARY

While debugging a unit test I noticed we're on an ancient version of sinon (4.5.0, released over 2 years ago). To make sure the problem isn't related to the old version of the library, I bumped sinon to the latest stable (9.0.2, released 2 months ago) and fixed breaking changes caused by renaming of spy.reset() to spy.resetHistory() .

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #9926 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9926      +/-   ##
==========================================
+ Coverage   71.22%   71.24%   +0.01%     
==========================================
  Files         585      585              
  Lines       30871    30871              
  Branches     3239     3239              
==========================================
+ Hits        21989    21993       +4     
+ Misses       8773     8769       -4     
  Partials      109      109              
Flag Coverage Δ
#cypress 53.83% <ø> (+0.07%) ⬆️
#javascript 59.41% <ø> (ø)
#python 71.41% <ø> (ø)
Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 87.64% <0.00%> (+1.12%) ⬆️
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 72.72% <0.00%> (+6.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b843e...f9c67b4. Read the comment docs.

@villebro villebro changed the title feat: bump sinon to latest stable version test: bump sinon to latest stable version May 27, 2020
@villebro villebro requested review from etr2460 and rusackas May 27, 2020 10:13
@villebro villebro merged commit 5ff6104 into apache:master May 27, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants