SYNCOPE-721 i18n added #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| <div class="text-center" ng-show="$root.isSelfRegAllowed()"> | ||
| <a href="javascript:void(0);" class="btn btn-link" ng-click="selfCreate()">Self Registration</a> | ||
|
|
||
| <a href="javascript:void(0);" class="btn btn-link" ng-click="selfCreate()">{{ 'SELFREGISTRATION' | translate}}</a> | ||
| <!-- <div id="initialLoaderDiv"> |
There was a problem hiding this comment.
Can you continue removing such commented code?
|
Thanks @mteo your PR looks generally good: I haven't tested it yet tough: I'll do and let you know. I have also added some comments suggesting few changes. Finally, since you have added a couple of new dependencies for I have developed a simple tool to automate this task, maybe I can land a hand once you're done with other changes. |
|
pr is now completed: translate library version updated, LICENSE and NOTICE files have been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.