-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code cleanup; diamond ops && lambda refs #279
Conversation
@mmoayyed thanks for taking care of such cleanup: would it be possible to remove the formatting changes from the PR? |
@mmoayyed it seems that Travis CI is failing due to a JDK bug like https://stackoverflow.com/questions/54775253/jdk-11-0-2-compilation-fails-with-javac-npe-on-anonymous-parameterized-class-typ |
I don't think formatting changes can be undone, since the fix are not manually made and are a result of automated tools. If you wish to see the changes without formatting changes, you can use this link: https://github.com/apache/syncope/pull/279/files?w=1 Travis CI issues are the result of an old bug in JDK that has since been patches; nothing we can do without significant changes to the Travis CI which should be disabled anyway, since that is not the main CI and just creates extra unnecessary work. |
@mmoayyed I see about formatting changes. About Travis CI, instead, the checks done there are currently not performed with GitHub Actions (as they require Docker and might involve some work); hence, we cannot ATM disable Travis CI. |
Github Actions natively supports Docker with almost no effort; so probably a better task would be to disable Travis CI and instead focus the effort to move the Travis CI tests over to GH actions, rather than maintaining two separate builds. I can certainly help with that. |
@mmoayyed please merge latest changes from |
This is purely a code clean-up patch: