Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

TAJO-1450 Encapsulate Datum in Tuple #465

Closed
wants to merge 1 commit into from
Closed

Conversation

navis
Copy link
Contributor

@navis navis commented Mar 26, 2015

Not completed, but still worthy, imho.

@jihoonson
Copy link
Contributor

Hi @navis. Thanks for your contribution. This is a necessary work.
I looked over the whole patch. In overall, it seems good to me.
Today I'm off, so it is difficult to leave comments without any computers. I'll finish my review soon.

@jihoonson
Copy link
Contributor

Sorry for late review. Would you please rebase?

}
} catch (RuntimeException e) {
e.printStackTrace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block looks for debug.

@jihoonson
Copy link
Contributor

Hi @navis, thanks for nice work.
I left trivial comments, and have an additional question.
I found that you changed many parts to use VTuple rather than Tuple. Do you have any reasons?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants