-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4388: Asynchttpclient can cause stuck TezChild processes #189
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
could you review this @rbalamohan ? I'm hoping that you're still familiar with async http client |
I've just realized this patch NULLs out the static client and forces the next async http connection to create one...I'm not sure this is the perfect solution, let me investigate this further |
4b87b79
to
7265e6c
Compare
7265e6c
to
437de2b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
TezRuntimeShutdownHandler.addShutdownTask(new Thread(() -> { | ||
try { | ||
if (httpAsyncClient != null) { | ||
httpAsyncClient.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should httpAsyncClient be set to "null" explicitly as well? Without it, it may create issues during container reuse. i.e httpAsyncClient will not be null, but in closed state & system would try to use it leading to exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @rbalamohan, makes sense, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor comment.
8ee557a
to
27d3f7e
Compare
LGTM. +1 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
27d3f7e
to
ad551af
Compare
💔 -1 overall
This message was automatically generated. |
…Laszlo Bodor reviewed by Rajesh Balamohan)
No description provided.