TEZ-4075: Reimplement tez.runtime.transfer.data-via-events.enabled #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidseth
approved these changes
Oct 5, 2019
| public static final String TEZ_RUNTIME_TRANSFER_DATA_VIA_EVENTS_ENABLED = | ||
| TEZ_RUNTIME_PREFIX + "transfer.data-via-events.enabled"; | ||
| @Private | ||
| public static final boolean TEZ_RUNTIME_TRANSFER_DATA_VIA_EVENTS_ENABLED_DEFAULT = true; |
There was a problem hiding this comment.
Do we want to enable this by default?
There was a problem hiding this comment.
Thanks @sidseth . Marking it as false in next commit.
|
precommit tests are done (https://issues.apache.org/jira/browse/TEZ-4075?focusedCommentId=16945612&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16945612). Merging this PR. Thanks @sidseth , Richard Zhang. |
abstractdog
pushed a commit
to abstractdog/tez
that referenced
this pull request
Sep 8, 2020
…enabled (apache#48) (Contributed by Richard Zhang) * TEZ-4075: Reimplement tez.runtime.transfer.data-via-events.enabled * TEZ-4075: Reimplement tez.runtime.transfer.data-via-events.enabled (cherry picked from commit a952709171d0ef0c3647c014027252fb8d36cedb) (cherry picked from commit be4d3ed930742630c4e1f9a5b95aaf1f55134d16) Change-Id: I0395d087f8e5eb80a807c459dc8a391b7fca9cbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR request based on https://issues.apache.org/jira/browse/TEZ-4075?focusedCommentId=16944252&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16944252
This enables data transfer over wire. In subsequent jira, in memory caching can be enabled for IFile. Details are provided in the link posted earlier.