-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4270: HeartbeatHandlerBase Does Not Need Stop Condition #93
Conversation
Tests failed because no unit tests added, but since this is an optimization, there is no change in behavior, no tests required. Please consider for merge. |
@abstractdog Can you please take a look? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this patch makes sense to me, I cannot see any particular reason why the stopped flag is used (e.g. added as a bug fix, or any kind of specific logic using it as AsyncDispatcher), it's present since an initial commit
+1, pending tests
@belugabehr: could you please rebase (=retrigger) this PR to get test coverage
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
merged to master, thanks @belugabehr for the patch! |
No description provided.