[THRIFT-5757] Unit tests for php lib

apache · Mar 4, 2024 · 525690d · 525690d
1 parent 17009c3
commit 525690d
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 1 deletion.
diff --git a/lib/php/phpunit.xml b/lib/php/phpunit.xml
@@ -26,7 +26,6 @@
          convertWarningsToExceptions="true"
          stopOnWarning="true"
          stopOnFailure="true"
-         processIsolation="true"
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
     <filter>
         <whitelist processUncoveredFilesFromWhitelist="true">

diff --git a/lib/php/test/Unit/BinarySerializerTest.php b/lib/php/test/Unit/BinarySerializerTest.php
@@ -28,6 +28,9 @@
 /***
  * This test suite depends on running the compiler against the ./Resources/ThriftTest.thrift file:
  * lib/php/test$ ../../../compiler/cpp/thrift --gen php -r  --out ./Resources/packages/php ./Resources/ThriftTest.thrift
+ *
+ * @runInSeparateProcess
+ * @preserveGlobalState false
  */
 class BinarySerializerTest extends TestCase
 {

diff --git a/lib/php/test/Unit/JsonSerializeTest.php b/lib/php/test/Unit/JsonSerializeTest.php
@@ -28,6 +28,9 @@
 /***
  * This test suite depends on running the compiler against the ./Resources/ThriftTest.thrift file:
  * lib/php/test$ ../../../compiler/cpp/thrift --gen php:json -r  --out ./Resources/packages/phpjs ./Resources/ThriftTest.thrift
+ *
+ * @runInSeparateProcess
+ * @preserveGlobalState false
  */
 class JsonSerializeTest extends TestCase
 {

diff --git a/lib/php/test/Unit/TJSONProtocolTest.php b/lib/php/test/Unit/TJSONProtocolTest.php
@@ -31,6 +31,9 @@
 /***
  * This test suite depends on running the compiler against the ./Resources/ThriftTest.thrift file:
  * lib/php/test$ ../../../compiler/cpp/thrift --gen php -r  --out ./Resources/packages/php ./Resources/ThriftTest.thrift
+ *
+ * @runInSeparateProcess
+ * @preserveGlobalState false
  */
 class TJSONProtocolTest extends TestCase
 {

diff --git a/lib/php/test/Unit/TSimpleJSONProtocolTest.php b/lib/php/test/Unit/TSimpleJSONProtocolTest.php
@@ -31,6 +31,9 @@
 /***
  * This test suite depends on running the compiler against the ./Resources/ThriftTest.thrift file:
  * lib/php/test$ ../../../compiler/cpp/thrift --gen php -r  --out ./Resources/packages/php ./Resources/ThriftTest.thrift
+ *
+ * @runInSeparateProcess
+ * @preserveGlobalState false
  */
 class TSimpleJSONProtocolTest extends TestCase
 {

diff --git a/lib/php/test/Unit/ValidatorTest.php b/lib/php/test/Unit/ValidatorTest.php
@@ -26,6 +26,9 @@
 /***
  * This test suite depends on running the compiler against the ./Resources/ThriftTest.thrift file:
  * lib/php/test$ ../../../compiler/cpp/thrift --gen php:validate -r  --out ./Resources/packages/phpv ./Resources/ThriftTest.thrift
+ *
+ * @runInSeparateProcess
+ * @preserveGlobalState false
  */
 class ValidatorTest extends BaseValidatorTest
 {

diff --git a/lib/php/test/Unit/ValidatorTestOop.php b/lib/php/test/Unit/ValidatorTestOop.php
@@ -26,6 +26,9 @@
 /***
  * This test suite depends on running the compiler against the ./Resources/ThriftTest.thrift file:
  * lib/php/test$ ../../../compiler/cpp/thrift --gen php:validate,oop -r --out ./Resources/packages/phpvo ./Resources/ThriftTest.thrift
+ *
+ * @runInSeparateProcess
+ * @preserveGlobalState false
  */
 class ValidatorTestOop extends BaseValidatorTest
 {