Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nonblocking SSL java client #1114

Closed
wants to merge 1 commit into from
Closed

Conversation

dthaluru
Copy link
Contributor

No description provided.

@nsuke
Copy link
Member

nsuke commented Nov 13, 2016

@dthaluru I think we can avoid duplicating the entire client stack.
As far as I can see the only thing that really matters is TNonblockingSSLSocket.
If we make it compatible with TNonblockingTransport, almost anything else would not be needed any longer.

The most significant incompatibility is int read(ByteBuffer) v.s. ByteBuffer read(int).
Would it be possible for TNonblockingSSLSocket to accept and reuse ByteBuffer so that the method signature can be the same ?

Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on comments from @nsuke I am requesting additional changes be made to simplify the solution.

@dthaluru
Copy link
Contributor Author

dthaluru commented Feb 2, 2017

Thanks for your replies. Sorry, I will send update pull request soon. I can close pull request for now and will send again later.

@dthaluru dthaluru closed this Feb 3, 2017
Jens-G pushed a commit to Jens-G/thrift that referenced this pull request Apr 14, 2019
…ed even when a base-error-message is provided; either way, *only* report the Command, not the CommandAndKey (we will add that later if detail is permitted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants