THRIFT-3960: Inherited services in Lua generator are not named correctly #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadLinux
pushed a commit
to gadLinux/thrift
that referenced
this pull request
Jan 24, 2017
Client: Lua Patch: Benjamin Gould <bgould@users.noreply.github.com> This closes apache#1124
ngrewe
pushed a commit
to ngrewe/thrift
that referenced
this pull request
Jan 31, 2017
Client: Lua Patch: Benjamin Gould <bgould@users.noreply.github.com> This closes apache#1124
ngrewe
pushed a commit
to ngrewe/thrift
that referenced
this pull request
Jan 31, 2017
Client: Lua Patch: Benjamin Gould <bgould@users.noreply.github.com> This closes apache#1124
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: Lua Patch: Benjamin Gould <bgould@users.noreply.github.com> This closes apache#1124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Lua generator, services that are inherited have an incorrectly named processor (the pointer to the parent service is being output to stream instead of the name of parent service)