THRIFT-4206: Fix decoding of strings in containers with py:dynamic and py:utf8strings #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
changed the title
|
Could you rebase on master and refresh the PR so we get a clean build, now that CI is stable again? Thanks. |
_read_by_ttype and _write_by_ttype must be using the *element* spec and not the container spec when determining the correct read/write handler.
elprans
force-pushed
the
py-strings-in-containers
branch
from
6edf57c
to
0c7cb79
Compare
|
Rebased. |
jeking3
approved these changes
Sep 26, 2017
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
…d py:utf8strings Client: py _read_by_ttype and _write_by_ttype must be using the *element* spec and not the container spec when determining the correct read/write handler. This closes apache#1273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_read_by_ttype and _write_by_ttype must be using the element spec
and not the container spec when determining the correct read/write
handler.