THRIFT-4215/4216 Make transport factories return errors #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the signature of TTransportFactory.GetTransport from GetTransport(trans TTransport) TTransport to GetTransport(trans TTransport) (TTransport, error) so the factory can pass any underlying error to the caller (previously such errors were ignored). This is a backwards incompatible change for anyone implementing custom transports, but it shouldn't effect anyone using the ones in this library. Fixes THRIFT-4215. Fixes THRIFT-4216.
|
Closing PR until all tests are fixed, I don't want to waste Apache's Travis capacity. |
asfgit
pushed a commit
that referenced
this pull request
Jun 5, 2017
Client: Go Patch: D. Can Celasun <can@dcc.im> This closes #1285
peterbourgon
added a commit
to go-kit/kit
that referenced
this pull request
Jun 6, 2017
|
For the record, this caused build failures in Go kit; I don't imagine my usage is particularly strange, but maybe it is. (Link.) |
|
Yes sorry about that, this was an expected breakage as the interface has changed. I suggest using EDIT: Just realized this is for go-kit, so you can't really vendor thrift. Maybe a note in the README might be useful. |
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Aug 5, 2017
Client: Go Patch: D. Can Celasun <can@dcc.im> This closes apache#1285
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: Go Patch: D. Can Celasun <can@dcc.im> This closes apache#1285
ridv
pushed a commit
to ridv/thrift
that referenced
this pull request
Jun 27, 2018
Client: Go Patch: D. Can Celasun <can@dcc.im> This closes apache#1285
ridv
pushed a commit
to ridv/thrift
that referenced
this pull request
Jun 27, 2018
Client: Go Patch: D. Can Celasun <can@dcc.im> This closes apache#1285
hsanjuan
pushed a commit
to gxed/thrift-go
that referenced
this pull request
Jan 30, 2019
Client: Go Patch: D. Can Celasun <can@dcc.im> This closes apache#1285
sagikazarmark
pushed a commit
to go-kit/examples
that referenced
this pull request
Jun 4, 2021
muscliary
pushed a commit
to muscliary/kit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the signature of
TTransportFactory.GetTransportfromto
so the factory can pass any underlying error to the caller (previously such errors were ignored).
This is a backwards incompatible change for anyone implementing custom transports, but it shouldn't effect anyone using the ones in this library.
Fixes THRIFT-4215.
Fixes THRIFT-4216.
P.S: Some files have formatting-only changes due to
gofmt.