THRIFT-4327: add API to efficiently remove a single timer #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
reviewed
Sep 13, 2017
| @@ -69,28 +72,33 @@ class TimerManager { | |||
| * | |||
| * @param task The task to execute | |||
| * @param timeout Time in milliseconds to delay before executing task | |||
| * @return Handle of the timer, which can be used to remose the timer. | |||
| timerManager.add(task, task->_timeout); | ||
|
|
||
| // Remove one task and wait until the other has completed | ||
| timerManager.remove(timer); |
There was a problem hiding this comment.
recommend calling remove a second time and validating expected behavior
| * @throws UncancellableTaskException Specified task is already being | ||
| * executed or has completed execution. | ||
| */ | ||
| virtual void remove(Timer timer); |
There was a problem hiding this comment.
Was removal of a task insufficient in some way?
There was a problem hiding this comment.
The old function removes all timers executing this task, and does this inefficiently by traversing the whole list.
This new function removes a single timer in constant time [O(1)] which may be significant for large system with many timers.
This does not impact the behavior of Thrift itself, since it does not rely on timer removal.
francoisferrand
force-pushed
the
THRIFT-4327
branch
from
d1fd82a
to
e37c14a
Compare
jeking3
approved these changes
Sep 14, 2017
gadLinux
pushed a commit
to gadLinux/thrift
that referenced
this pull request
Sep 22, 2017
Client: C++ This closes apache#1353
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: C++ This closes apache#1353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.