make thrift cocoa lib support TMultiplexedProtocol

[guoyalun]

make thrift cocoa lib support TMultiplexedProtocol , so that thrift support mutil service .

[Jens-G]

Hi guoyalun ,
that's great!

Could you just file a JIRA ticket and reference it here?
http://thrift.apache.org/docs/HowToContribute

Thanks!
JensG

[drobakowski]

Hi @guoyalun,

before you create a new JIRA ticket, i think this duplicates my ticket THRIFT-2144 as well as parts of the unmerged PR #49. I'm currently rebasing my closed and unmerged PRs.

Greets,
David

[Jens-G]

Hi @guoyalun and @drobakowski,

I'd really like you both to agree upon one patch set, which will finally be committed to the Thrift code base. That way we could involve more knowledgeable eyes to look out for problems.

[drobakowski]

Hi @Jens-G,

absolutely, whatever it takes to get one or the other patch committed! :) I will try to show the main differences from my point of view.

• ARC:
  • My patch is backward compatible with non ARC Objective-C code and uses the retain_stub/dealloc_stub/release_stub/autorelease_stub functions for dealing with memory allocs etc.
  • @guoyalun version is not.
• In writeMessageBeginWithName:

switch (messageType) {
    case TMessageType_CALL:
    case TMessageType_ONEWAY:
…

vs.

if (messageType == TMessageType_CALL || messageType == TMessageType_ONEWAY) {
…

where i prefer my switch statement because it's a direct jump at runtime.

NSMutableString * serviceFunction = [[NSMutableString alloc] initWithString:mServiceName];
[serviceFunction appendString:MULTIPLEXED_SERVICE_SEPERATOR];
[serviceFunction appendString:name];
…

vs.

NSString *messageName = [NSString stringWithFormat:@"%@%@%@",_serviceName,SEPARATOR,name];

I’m not sure which one is better and should be used according to memory/performance usage. According to memory usage, I think I've read somewhere that NSMutableString should perform better in this case but I don't have enough experience with Objective-C, @Jens-G, @guoyalun do you have some advice? Sure @guoyalun version looks cleaner.

@guoyalun did I miss something, whats your opinion to the differences?

[bufferoverflow]

please add apache license header