tutorial/erl/*.sh: change the order of symlinks #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid dangling symlink on Windows (breaks gnu tar)
jeking3
approved these changes
Jun 7, 2018
|
THRIFT-4580 |
djzort
pushed a commit
to djzort/thrift
that referenced
this pull request
Oct 15, 2018
djzort
pushed a commit
to djzort/thrift
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tutorial/erl/client.sh is a symlink to tutorial/erl/server.sh. During extraction of a thrift archive on Windows, this creates temporarily a dangling symlink, because client.sh is extracted before server.sh, and points to a (then) non-existing file. This breaks tar on Windows:
A simple workaround is to change the order of symlinks in thrift. The archive typically has the files in alphabetical order, so the target will exist when the symlink is extracted.