Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4546: replace all git-wip-us.apache.org #1651

Merged
merged 1 commit into from Dec 28, 2018
Merged

THRIFT-4546: replace all git-wip-us.apache.org #1651

merged 1 commit into from Dec 28, 2018

Conversation

robberphex
Copy link
Contributor

No description provided.

@robberphex robberphex force-pushed the THRIFT-4546 branch 2 times, most recently from be992a3 to 874e63d Compare December 27, 2018 16:07
@dcelasun
Copy link
Member

Why not use Github instead of Gitbox? We already do that for the Go library.

@robberphex
Copy link
Contributor Author

https://github.com/apache/thrift is just a mirror of Gitbox.
Technically, the work flow doesn't relay on GitHub. That's why we used git-wip-us, and why we use gitbox.

@dcelasun
Copy link
Member

dcelasun commented Dec 27, 2018 •
edited

I think it's the other way around, pushes to Github are mirrored to Gitbox. I've personally never pushed to Gitbox.

I also distinctly remember (because it became a problem for Go) us calling Github the official primary repo after git-wip-us was shutdown.

jeking3
jeking3 requested changes Dec 27, 2018
View reviewed changes
Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official repository is github, not gitbox.

@robberphex robberphex changed the title THRIFT-4546: replace all git-wip-us.apache.org to gitbox.apache.org THRIFT-4546: replace all git-wip-us.apache.org Dec 28, 2018
@jeking3 jeking3 merged commit a139082 into apache:master Dec 28, 2018
@robberphex robberphex deleted the THRIFT-4546 branch December 28, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeking3 jeking3 jeking3 approved these changes

Assignees
No one assigned
Labels
cosmetic
Projects
None yet
Milestone
No milestone
3 participants
@robberphex @dcelasun @jeking3