THRIFT-4547: add swift to bionic build image and run unit tests #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurikoles
approved these changes
Jan 1, 2019
|
Sadly, it didn't actually run the swift unit tests. |
|
@jeking3 |
|
You can run the CI in your own fork. |
|
That's normal (build job will be skipped) that's just a docker image build job if needed. The bionic build below didn't run the swift "make check". |
jeking3
force-pushed
the
THRIFT-4547-swift-cross
branch
from
123ae05
to
2882ef3
Compare
jeking3
force-pushed
the
THRIFT-4547-swift-cross
branch
from
2882ef3
to
cfb0dae
Compare
|
I had forgotten to add swift as a SUBDIRS entry in the lib/Makefile.am - I believe that's all set now. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite to writing and running swift clients and servers in the cross test.