Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4713: Review of TBaseHelper #1665

Merged
merged 1 commit into from
Jan 2, 2019
Merged

THRIFT-4713: Review of TBaseHelper #1665

merged 1 commit into from
Jan 2, 2019

Conversation

belugabehr
Copy link
Contributor

@jeking3 Hey, I was already working on this one, so I'll submit it. However, I'll take a look at any existing tickets now.

@jeking3
Copy link
Contributor

jeking3 commented Jan 2, 2019

How certain are we that these code paths are properly unit tested?

@belugabehr
Copy link
Contributor Author

@jeking3 Feel pretty good about it.

https://github.com/BELUGABEHR/thrift/blob/master/lib/java/test/org/apache/thrift/TestTBaseHelper.java

  • copyBinary
  • testSets
  • testNestedStructures (test comparison of List types)

@jeking3 jeking3 merged commit 1c6914d into apache:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
2 participants
@belugabehr @jeking3