Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-4368: Fix guaranteed NPE in TBaseAsyncProcessor.java #1669

Merged
merged 1 commit into from Jan 4, 2019
Merged

THRIFT-4368: Fix guaranteed NPE in TBaseAsyncProcessor.java #1669

merged 1 commit into from Jan 4, 2019

Conversation

belugabehr
Copy link
Contributor

No description provided.

jeking3
jeking3 requested changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original logic was correct, it should eat the incoming struct and reply if the request was a CALL which means a two-way request/response. It needs to signal readiness as well. All of that was removed.

Instead, we should only change line 57 to be correct.

lib/java/src/org/apache/thrift/TBaseAsyncProcessor.java Outdated Show resolved Hide resolved
lib/java/src/org/apache/thrift/TBaseAsyncProcessor.java Outdated Show resolved Hide resolved
lib/java/src/org/apache/thrift/TBaseAsyncProcessor.java Show resolved Hide resolved
@jeking3 jeking3 added the bugfix label Jan 3, 2019
jeking3
jeking3 requested changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@jeking3 jeking3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not correct, and obviously we don't have a good test for it. I don't think any async servers are tested in the cross tests.

lib/java/src/org/apache/thrift/TBaseAsyncProcessor.java Outdated Show resolved Hide resolved
@belugabehr
THRIFT-4368: Fix guaranteed NPE in TBaseAsyncProcessor.java
a1f5b7e 
wq# Please enter the commit message for your changes. Lines starting
@jeking3 jeking3 merged commit d532441 into apache:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeking3 jeking3 jeking3 approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
2 participants
@belugabehr @jeking3