THRIFT-4732: windows cmake refinements and add windows docker build support #1687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for a Windows Docker container which successfully builds the portable windows thrift compiler (statically linked to runtime).
I also did some refactoring on cmake and introduced the potential to get windows to work properly with shared libraries, but it doesn't quite work. The default for WIN32 is -DBUILD_SHARED_LIBS=OFF and the default for other platforms is ON.
I also removed the defunct build/wincpp which turned into the appveyor framework.
Fixed "cl" (LISP) language generator missing from the cmake file for the compiler.