Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-4732: windows cmake refinements and add windows docker build support #1687

Merged
merged 1 commit into from Jan 12, 2019

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Jan 11, 2019

This adds initial support for a Windows Docker container which successfully builds the portable windows thrift compiler (statically linked to runtime).

I also did some refactoring on cmake and introduced the potential to get windows to work properly with shared libraries, but it doesn't quite work. The default for WIN32 is -DBUILD_SHARED_LIBS=OFF and the default for other platforms is ON.

I also removed the defunct build/wincpp which turned into the appveyor framework.

Fixed "cl" (LISP) language generator missing from the cmake file for the compiler.

@cyyever
Copy link
Contributor

cyyever commented Jan 12, 2019

lib/cpp/libthrift.sln and lib/cpp/libthrift.vcxproj* are out of date and should be removed. Using cmake as the only method for building on Windows ?

@jeking3
Copy link
Contributor Author

jeking3 commented Jan 12, 2019

There is already a backlog item for that: See THRIFT-3973, THRIFT-4025
It involves removing the static projects that are checked in, and then updating the documentation. Some of the documentation is on the ASF CMS and not in GitHub. The project docs are a bit of a mess unfortunately, but I agree with the direction.

@jeking3
Copy link
Contributor Author

jeking3 commented Jan 12, 2019

@cyyever If you want to experiment with building shared libraries on Windows, try cmake -DBUILD_SHARED_LIBS=ON - the CMake project is ready but there are some loose ends to clean up.

@jeking3 jeking3 merged commit 278528c into apache:master Jan 12, 2019
@jeking3 jeking3 deleted the windows-docker branch January 12, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants