THRIFT-4839: Remove embedded buffering/framed options from TCP transp… #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orts Client: netstd Patch: Kyle Smith
|
As I was working on this, I was wondering if "buffering" is the correct term. Would "mode" make more sense? As in transport mode? |
|
Separation of transport concepts is great to see. |
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Mar 26, 2019
…orts Client: netstd Patch: Kyle Smith + minor changes by Jens Geyer This closes apache#1770
|
Looking at it ... Re mode: "Buffering" may not be the best choice ever, but "mode"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…orts
Client: netstd
Patch: Kyle Smith
Removed the embedded buffered/framed code from the socket and tls socket transports. I also updated the tests and tutorial files to use the existing TFramedTransport.Factory and TBufferedTransport.Factory classes.